Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A bug in src/ws/WSHandler.cpp #26

Closed
schyjxy opened this issue Oct 27, 2021 · 2 comments
Closed

A bug in src/ws/WSHandler.cpp #26

schyjxy opened this issue Oct 27, 2021 · 2 comments
Labels
bug

Comments

@schyjxy
Copy link

schyjxy commented Oct 27, 2021

src/ws/WSHandler.cpp，line 174、199, if len == pos，data[pos++] will be out of bounds , and the variate ctx_.hdr.xpl.xpl16 will be set wrong value.
@Jamol Jamol added the bug label Oct 28, 2021
@Jamol
Copy link
Owner

Jamol commented Oct 28, 2021

Thanks for report this. line 174 is a bug, line 199 should be OK since it checked pos<len

Jamol added a commit that referenced this issue Oct 28, 2021
@Jamol
fix issue #26
5e75555 
update libkev
Jamol added a commit that referenced this issue Oct 28, 2021
@Jamol
Merge pull request #27 from Jamol/fix
139a75f 
fix issue #26
@Jamol
Copy link
Owner

Jamol commented Oct 28, 2021

fixed

@Jamol Jamol closed this as completed Oct 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Jamol @schyjxy