Add final configurations; same as releaseltcg but define _FINAL. #14
Conversation
|
I'd rather keep this kind of thing project-specific, personally, to avoid bloating the number of configurations that need to be maintained. That, and release and debug aren't even particularly standard as it is (e.g. my release is what you call final), I think getting people to agree on other standard configurations is going to be tough! |
|
Is it possible for the final configurations to include release and then just define _FINAL? That would fix the maintenance side of it. I understand and somewhat agree with the comment, although I kind of feel for big games at least a final configuration is common enough that it would be a benefit to JamPlus for developers to be able to grab it and have final configurations available without any extra work. My view is that (as you say) debug and release don't mean anything really, just some words that give people some idea about compiler optimizations, runtime, NDEBUG etc. but they are provided as they are handy for most developers, if final too could be handy in the same way perhaps it is worth including. Anyway, that is my argument for, I have gone about five years having all final/ad hoc/distribution configurations locally, and am happy to continue this, just want to try and make JamPlus as good as possible :-) -------- Original message -------- I'd rather keep this kind of thing project-specific, personally, to avoid bloating the number of configurations that need to be maintained. That, and release and debug aren't even particularly standard as it is (e.g. my release is what you call final), I think getting people to agree on other standard configurations is going to be tough! — |
|
Including configurations from others would be great, and would mean some of the existing ones could be tidied up nicely too. Not sure if that's doable right now though! Good points, I see where you're coming from, and I imagine a final configuration will be useful to many people. I guess it's entirely a personal preference thing though, so let's see what Josh wants :) |
|
No movement on this issue so far ;o) @jamplus could you clarify whether you are still deliberating on this, or whether you decided against inclusion of a final configuration. |
All the companies I have worked at have required a final configuration. The typical set up I have encountered is along the lines of:
debug : _DEBUG defined, no optimizations
release : NDEBUG defined, optimizations
final : NDEBUG _FINAL defined, optimizations
On top of this; for iOS/OSX builds, typically additional configurations are used:
adhoc : NDEBUG _FINAL defined, optimizations
distribution : NDEBUG _FINAL _DISTRIBUTION defined, optimizations
Although AdHoc looks the same as Final (on the face of it) it will be using different code signing identify and provisioning profile.
As I am not sure whether you will wish to take these changes main line or not, I am splitting the final and adhoc/distribution into two separate pull requests. From my point of view I'd like you to take them all, but if you felt one or the other were acceptable that would also be beneficial I imagine.