-
-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Trades for different securities are mixed together #53
Comments
Symbol should be the last parameter used. Can you check the ISIN, CUSIP, securityID of these two companies/trades and whether any of these matches? If symbol is really the only matching parameter between the two, we need to take a look into why the code is not behaving as expected. |
Definitely different ISINs:
Now the thing is, entries and exits were via long/short call or put options. So I think that there is something going on in that part of the code. I am trying to figure out why assignments are falling into the wrong ticker. |
I see where the issue is, give me half an hour. |
@pronebird try this: #54 |
Looks like it works as expected after your patch. The only issue is, E-davki is being silly telling me that there are two securities with the same symbol. I suppose it's a bug on their side, they should probably use ISIN or whatever, so manually editing symbols and adding something to distinguish them did the trick. Ideally we could add the country of origin from ISIN to the name of contract, i.e |
Hi,
I hold positions in both WT WEAT trading on LSE and Teucrium WEAT trading on NYSE. It's the same symbol, but different exchange and price. WT WEAT on LSE trades at a fraction of dollar, while Teucrium WEAT on NYSE trades at an order of magnitude of WT WEAT.
I think the script cannot solely rely on
symbol
. Same logic applies tocompanies.xml
, eitherconid
orsecurityID
should be used instead to distinguish between securities.The text was updated successfully, but these errors were encountered: