Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The callback should be called with the data. #1

Open
praveensanap opened this issue Dec 2, 2017 · 3 comments
Open

The callback should be called with the data. #1

praveensanap opened this issue Dec 2, 2017 · 3 comments

Comments

@praveensanap
Copy link

task.callback();

@jan25
Copy link
Owner

jan25 commented Dec 2, 2017

The logic inside execute is not fixed. I think even the logic has to be passed somehow as callback.
In this code, it is ajax. but async task can be anything.

@praveensanap
Copy link
Author

Yep. this library shouldn't assume you have to do an ajax.
In execute just call the callback with err or data.

@jan25
Copy link
Owner

jan25 commented Dec 2, 2017

// task => {

Here asyncTask must return a Promise

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants