Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Symfony 6.3 - JaneObjectNormalizer should implement DenormalizerInterface::getSupportedTypes #727

Closed
DjordyKoert opened this issue Jun 2, 2023 · 4 comments · Fixed by #739
Labels

Comments

@DjordyKoert
Copy link

Jane version(s) affected: 7.5.0

Description

Symfony 6.3 has been released and has made a change in the way they handle normalizer caching to increase performance. This causes a deprecation warning to be thrown inside the JaneObjectNormalizer.

How to reproduce

Simply update to symfony 6.3 while making use of this package.

Possible Solution

Implement the getSupportedTypes(?string $format): array method to all normalizers

Additional context

Symfony blog can be read here: New in Symfony 6.3: Performance Improvements

New interface method source code (permalink)

@adrolter
Copy link

adrolter commented Jun 24, 2023

Has anyone worked on this?

Edit: I created a patch against my vendor dir...if there is interest for me to turn it into a PR please let me know https://gist.github.com/adrianguenter/71c74201be41e0e619d09086cb555b62

@DjordyKoert
Copy link
Author

@adrianguenter I would be interested in a PR, since this would remove these deprecation warnings from our logging 😄

@Korbeil
Copy link
Member

Korbeil commented Jul 7, 2023

I'll handle this for next version ~ Sorry for the delay

@Korbeil
Copy link
Member

Korbeil commented Jul 7, 2023

Could someone check the linked PR ? If it seems good to you I'll merge it and tag a new version 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants