Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows compatibility #71

Closed
db4 opened this issue Mar 28, 2019 · 2 comments
Closed

Windows compatibility #71

db4 opened this issue Mar 28, 2019 · 2 comments

Comments

@db4
Copy link
Contributor

db4 commented Mar 28, 2019

Trying to compile base under windows I get:

File "_build/default/src/mpopcnt.sexp", line 1, characters 1-11:                                          
12:411 | '(-mpopcnt)'
     ^^^^^^^^^^
Error: too many s-expressions found in input

After the following

--- a/src/dune
+++ b/src/dune
@@ -16,7 +16,7 @@
 
 (library (name base) (public_name base)
  (libraries caml sexplib0 shadow_stdlib) (install_c_headers internalhash)
- (c_flags :standard -D_LARGEFILE64_SOURCE (:include mpopcnt.sexp))
+ (c_flags :standard -D_LARGEFILE64_SOURCE)
  (c_names exn_stubs int_math_stubs internalhash_stubs hash_stubs am_testing)
  (preprocess no_preprocessing)
   (lint 

base builds OK, but I expect -mpopcnt option should be excluded automatically if not supported by C compiler (MSVC in my case)?

@seliopou
Copy link
Member

Thanks for reporting this.

This has been a perennial proble that I believe is in the process of being fixed internally. See #60 for some discussion. I'll leave this open until @diml's change lands.

@hhugo
Copy link
Contributor

hhugo commented May 28, 2019

Fixed in base v0.12.1. see ocaml/opam-repository#14171.

@hhugo hhugo closed this as completed May 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants