Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supporting the optional flag #10

Closed
pbiggar opened this issue Apr 9, 2020 · 3 comments
Closed

Supporting the optional flag #10

pbiggar opened this issue Apr 9, 2020 · 3 comments
Labels
forwarded-to-js-devs This report has been forwarded to Jane Street's internal review system.

Comments

@pbiggar
Copy link

pbiggar commented Apr 9, 2020

ppx_deriving supports an optional flag. From their docs:

It's possible to make deriving ignore a missing plugin rather than raising an error by passing an optional = true option, for example, to enable conditional compilation:

type addr = string * int
[@@deriving yojson { optional = true }]

This works well for their builtins, but doesn't seem to work for bin_io - which is making writing platform independent code difficult. Would you be able to support it?

@hhugo
Copy link

hhugo commented Apr 9, 2020

I believe this issue belongs to https://github.com/ocaml-ppx/ppxlib

@pbiggar
Copy link
Author

pbiggar commented Apr 9, 2020

Thanks @hhugo, will report it there.

@github-iron github-iron added the forwarded-to-js-devs This report has been forwarded to Jane Street's internal review system. label Jun 23, 2020
@aalekseyev
Copy link
Contributor

Closing this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
forwarded-to-js-devs This report has been forwarded to Jane Street's internal review system.
Projects
None yet
Development

No branches or pull requests

4 participants