New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nil string will unpack into empty string #14

Closed

khchen opened this issue Nov 25, 2017 · 1 comment

khchen commented Nov 25, 2017

proc unpack_type*(s: Stream, val: var string) =
  let pos = s.getPosition()
  if s.readChar == pack_value_nil:
    val = "" # should be nil here?
    return

Owner

jangko commented Nov 26, 2017 •

edited

Loading

should be nil here?

yes, the spec says, nil output should be nil, it is a bug.

jangko closed this as completed in

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment