Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Png is loaded incorrectly #1

Closed
yglukhov opened this issue Jan 14, 2016 · 5 comments
Closed

Png is loaded incorrectly #1

yglukhov opened this issue Jan 14, 2016 · 5 comments

Comments

@yglukhov
Copy link
Contributor

The following code, which just loads and saves a PNG produces artifacts with image attached:

let png = loadPNG32(original_path)
discard savePNG32(output_path, png.data, png.width, png.height)

Original image: edit: removed
Output image: edit: removed

@jangko
Copy link
Owner

jangko commented Jan 15, 2016

this is a bug in the encoder(savePNG), perhaps in the filter/interlace section.
it will take some time to fix it.

@yglukhov
Copy link
Contributor Author

I've observed similar artifacts when using saveBMP from nimBMP. That's why I thought the problem is in the loader. But if it's encoder, then nimBMP is also wrong.

@jangko
Copy link
Owner

jangko commented Jan 15, 2016

that is really strange, i don't experience the same thing with saveBMP, only with savePNG.
the decoder(loadPNG) is ok.

@yglukhov
Copy link
Contributor Author

Ok, sorry, my mistake. saveBMP is ok.

@jangko jangko closed this as completed in 8e492e0 Jan 18, 2016
jangko added a commit that referenced this issue Jan 18, 2016
@yglukhov
Copy link
Contributor Author

Works, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants