Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Problem with added back-button / history / bookmarking support for sub-tabs #11

Closed
ghost opened this issue Jul 15, 2011 · 4 comments
Closed

Comments

@ghost
Copy link

ghost commented Jul 15, 2011

Firstly great work on this, the history and back button works for sub-tabs great.

Just a small issue I've found, if no #tab-1 on page load then it breaks? only works if you start with /default.asp#tab-1 rather than displaying the first tab by default if no tab has been selected.

Hope this makes sense?

James

@ghost
Copy link
Author

ghost commented Jul 15, 2011

I've just added: window.location.hash = 'tab-1'; which rectifies this issue, or is there a cleaner way?

Thanks

@ghost
Copy link
Author

ghost commented Jul 15, 2011

Actually that doesn't work at all because if I had a link of a sub-tab in an email on window load it would go straight to #home instead of the actual sub-tab.

@mastersf
Copy link

Steve, thanks so much for adding this new feature. Incredible! And you did it so fast. Very appreciated!

With this new feature, however, the functionality of the script is entirely broken, for me. As James says, the page doesn't load with the first tab being active and I can't seem to set an li to be the defaultTab. Not sure what's going on. Also, if I don't link directly with a hash in the url to active a url the script doesn't even work when on the page and clicking the different tabs. Hmm

@JangoSteve
Copy link
Owner

Oops yeah, that was definitely a bug. I just fixed this (hopefully) in this commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants