Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: minimal deployment docker image #32

Closed
Tracked by #1081
tikikun opened this issue Sep 29, 2023 · 4 comments
Closed
Tracked by #1081

feat: minimal deployment docker image #32

tikikun opened this issue Sep 29, 2023 · 4 comments
Assignees
Labels
needs info Needs more logs, steps to help reproduce P1: important Important feature / fix

Comments

@tikikun
Copy link
Contributor

tikikun commented Sep 29, 2023

super small docker image for nitro

@tikikun tikikun added the P1: important Important feature / fix label Sep 29, 2023
@tikikun tikikun self-assigned this Sep 29, 2023
@hiro-v hiro-v self-assigned this Oct 2, 2023
@0xSage 0xSage added this to the Nitro v1.0.0 milestone Oct 10, 2023
@0xSage
Copy link
Contributor

0xSage commented Oct 10, 2023

What's the impact of this? What would devs/users be able to do?

@0xSage 0xSage added the needs info Needs more logs, steps to help reproduce label Oct 10, 2023
@hiro-v
Copy link
Contributor

hiro-v commented Oct 20, 2023

@0xSage
The initial thought for this one is similar to llama.cpp
However after some rounds of integration, I realized that this one might not be needed as we have release (nitro binary along with external deps. packaged to run).
User can just use that instead for better performance.

This is also needed as the guideline for user to pack nitro to deploy to cloud native services (i.e Kubernetes, Slurm, etc)

@hiro-v
Copy link
Contributor

hiro-v commented Oct 30, 2023

From what I can understand, we do not need to distribute the docker for this (dev/ release)
Nitro will always release just the binaries

@hiro-v hiro-v closed this as completed Oct 30, 2023
@101100
Copy link

101100 commented Jan 16, 2024

Providing a docker image would allow people to create a docker-compose.yml file that has Nitro and an application that uses the API, such as SillyTavern. The minimal size of Nitro makes it great for this type of use. Other people can create a docker image easily, but it is nice when it is provided by an official source so it is known to be up-to-date.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs info Needs more logs, steps to help reproduce P1: important Important feature / fix
Projects
Archived in project
Development

No branches or pull requests

4 participants