Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: cortex-cpp node addon #852

Merged
merged 7 commits into from
Jul 9, 2024
Merged

feat: cortex-cpp node addon #852

merged 7 commits into from
Jul 9, 2024

Conversation

louis-jan
Copy link
Contributor

@louis-jan louis-jan commented Jul 7, 2024 •
edited
Loading

Describe Your Changes

  • This PR is to build Cortex-CPP as a Node add-on binary, which allows Cortex-JS to bundle and import it natively.
  • Backend: cmake-js
  • Publish & Prebuild: prebuild (support both node-gyp & cmake-js backends)

This PR also support to pull vulkan support for cortex.llamacpp engine

cortex engines init cortex.llamacpp --vulkan

Next Actions:

  • CI Update

Fixes Issues

Self Checklist

  • Added relevant comments, esp in complex areas
  • Updated docs (for bug fixes / features)
  • Created issues for follow-up changes or refactoring needed

louis-jan
louis-jan commented Jul 7, 2024
View reviewed changes
cortex-cpp/index.js Outdated Show resolved Hide resolved
@louis-jan louis-jan force-pushed the feat/cortex-cpp-node-addon branch 29 times, most recently from 4e409b9 to 414f468 Compare July 8, 2024 15:13
@louis-jan louis-jan force-pushed the feat/cortex-cpp-node-addon branch 9 times, most recently from efcdbbd to c20cac5 Compare July 9, 2024 11:14
@louis-jan louis-jan marked this pull request as ready for review July 9, 2024 11:23
@louis-jan louis-jan merged commit 07cf2ff into dev Jul 9, 2024
5 checks passed
@louis-jan louis-jan deleted the feat/cortex-cpp-node-addon branch July 9, 2024 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vansangpfiev vansangpfiev vansangpfiev approved these changes

@marknguyen1302 marknguyen1302 Awaiting requested review from marknguyen1302

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

feat: cortex-cpp node binding feat: Cortex supports Vulkan?
2 participants
@louis-jan @vansangpfiev