You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Problem
In PR #948, we encountered an issue where we could not import node modules exported by @janhq/core but were only able to require them since modules were not exported accordingly.
In this PR, we refactored to have three exported modules:
@janhq/core: default UMD module root, serving as its core SDK, can be imported from both browsers and Node.
@janhq/core/sdk: ES5 core SDK module, importable from browser projects.
@janhq/core/node: CommonJS Node module, importable from Node projects.
Success Criteria
Refactored modules import
// from constnode=require('@janhq/core/dist/node/index.cjs')// toimport{ ... }from'@janhq/core/node'
Additional context
Include any other relevant context or screenshots about the feature request here.
The text was updated successfully, but these errors were encountered:
Problem
In PR #948, we encountered an issue where we could not import node modules exported by @janhq/core but were only able to require them since modules were not exported accordingly.
In this PR, we refactored to have three exported modules:
Success Criteria
Refactored modules import
Additional context
Include any other relevant context or screenshots about the feature request here.
The text was updated successfully, but these errors were encountered: