Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug: Import from HuggingFace with random string is causing app crash #2167

Closed
Van-QA opened this issue Feb 27, 2024 · 3 comments
Closed

bug: Import from HuggingFace with random string is causing app crash #2167

Van-QA opened this issue Feb 27, 2024 · 3 comments
Assignees
Labels
P1: important Important feature / fix type: bug Something isn't working
Milestone

Comments

@Van-QA
Copy link
Contributor

Van-QA commented Feb 27, 2024

Describe the bug
Import from HuggingFace with random string is causing app crash

Steps to reproduce
Steps to reproduce the behavior:

  1. Go to Hub
  2. Attempt to import from Hugging face using random value
    Expected behavior
    A clear and concise description of what you expected to happen.

Screenshots
image

image **Environment details** - Operating System: MacOS - Jan Version: latest nightly build - Processor: Apple M2 Pro - RAM: 16GB
@Van-QA Van-QA added the type: bug Something isn't working label Feb 27, 2024
@Van-QA Van-QA added this to the v0.4.8 milestone Feb 27, 2024
@Van-QA Van-QA added P0: critical Mission critical P1: important Important feature / fix and removed P1: important Important feature / fix P0: critical Mission critical labels Feb 27, 2024
@0xSage
Copy link
Contributor

0xSage commented Feb 28, 2024

Even not a random string crashes:
https://huggingface.co/TheBloke/Llama-2-7B-Chat-GGUF

Error: Cannot read properties of undefined (reading 'includes')
TypeError: Cannot read properties of undefined (reading 'includes')
at HuggingFaceRepoDataLoadedModal (file:///Applications/Jan.app/Contents/Resources/app.asar/renderer/_next/static/chunks/app/pag

@louis-jan
Copy link
Contributor

HelloYunho did a very great job on this, as he mentioned in the input box that users should input username/repo-name, not a random string or full HuggingFace URL. The feature will be marked as experimental, expecting bugs and set to be enhanced later.

Screenshot 2024-03-03 at 14 29 46 Screenshot 2024-03-03 at 14 33 40

@Van-QA Van-QA moved this to Icebox in Jan & Cortex Mar 6, 2024
@Van-QA
Copy link
Contributor Author

Van-QA commented Mar 6, 2024

Although the issue is resolved, the Import via Hugging Face is on hold until this epic https://github.com/janhq/cortex/issues/571 is resolved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1: important Important feature / fix type: bug Something isn't working
Projects
Archived in project
Development

No branches or pull requests

4 participants