Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Pick new model in thread if original model is unavailable #3385

Open
1 of 2 tasks
imtuyethan opened this issue Aug 15, 2024 · 8 comments
Open
1 of 2 tasks

feat: Pick new model in thread if original model is unavailable #3385

imtuyethan opened this issue Aug 15, 2024 · 8 comments
Assignees
Labels
category: threads & chat Threads & chat UI UX issues needs designs Needs designs P1: important Important feature / fix type: enhancement Improves a current feature

Comments

@imtuyethan
Copy link
Contributor

imtuyethan commented Aug 15, 2024

Problem

When user delete a model & go back to a specific threads that uses the deleted model:
E.g. Thread A uses model Llama 3 & user deletes model Llama 3 then go back to thread A & continue the chat...

Current behavior:
We switch to another model without user's permission, which is not cool.

Expected behavior:
We should inform user that the selected model is deleted & recommend them to download or select another model.

Design

  • Users have clear UX to direct them to pick new model if original thread model is unavailable
    • e.g. Remote model is unreachable (e.g. if offline)
    • e.g. Local model has been deleted
  • UX should be gentle and reassuring

Figma:
https://www.figma.com/design/DYfpMhf8qiSReKvYooBgDV/Jan-App-(3rd-version)?node-id=8322-71957&t=af5Wyb9D89fwRirc-4

Screenshot 2024-09-12 at 4 46 57 PM

  • When user tries to send a message -> show error: "Current model is not available. Please download or select a different one. "
  • When user opens Model Menu, they will see that the model is not downloaded.

Tasklist

Related Issues

@imtuyethan imtuyethan added this to the v.0.6.1 milestone Aug 15, 2024
@imtuyethan imtuyethan added the type: feature request A new feature label Aug 15, 2024
@imtuyethan imtuyethan removed this from the v.0.6.1 milestone Aug 22, 2024
@imtuyethan imtuyethan assigned imtuyethan and unassigned urmauur Aug 22, 2024
@imtuyethan imtuyethan added the needs designs Needs designs label Aug 22, 2024
@imtuyethan imtuyethan assigned louis-jan and unassigned imtuyethan Aug 29, 2024
@imtuyethan imtuyethan removed the needs designs Needs designs label Aug 29, 2024
@dan-homebrew dan-homebrew changed the title Edge case: User delete all models & API key but continue using old threads discussions: User delete all models & API key but continue using old threads Sep 3, 2024
@imtuyethan
Copy link
Contributor Author

@dan-homebrew
Copy link
Contributor

dan-homebrew commented Sep 3, 2024

I think there are two potential scenarios here:

  • Model has been deleted (or doesn't work) => choose new model
  • All models and Remote APIs have been deleted

My view is that we should prompt the user to choose, instead of just using "next model". That way, we can solve for both situations at once, and not add an unnecessary edge case:

Scenario 1: Thread model is deleted

  • Specific Thread's model is deleted
  • e.g. llama3 is deleted, and all 30 threads that use it don't have a model any more
  • Our response: "The previous model is no longer available. Please choose a new default model" -> Selector

@dan-homebrew dan-homebrew changed the title discussions: User delete all models & API key but continue using old threads feat: Existing Thread's model has been deleted Sep 3, 2024
@imtuyethan
Copy link
Contributor Author

Dup #3537

@louis-jan louis-jan changed the title feat: Existing Thread's model has been deleted Feat: Existing Thread's model has been deleted Sep 5, 2024
@imtuyethan imtuyethan added the needs pm Feature request is not clear, needs product decisions label Sep 6, 2024
@imtuyethan imtuyethan assigned imtuyethan and unassigned louis-jan Sep 6, 2024
@imtuyethan imtuyethan added needs designs Needs designs and removed needs designs Needs designs needs pm Feature request is not clear, needs product decisions labels Sep 6, 2024
@dan-homebrew dan-homebrew changed the title Feat: Existing Thread's model has been deleted Feat: Existing Thread's model is unavailable Sep 11, 2024
@dan-homebrew dan-homebrew changed the title Feat: Existing Thread's model is unavailable feat: Model no longer available in existing thread Sep 11, 2024
@dan-homebrew dan-homebrew changed the title feat: Model no longer available in existing thread feat: Pick new model in thread if original model is unavailable Sep 11, 2024
@dan-homebrew
Copy link
Contributor

@imtuyethan I am breaking up our original issue into two issues:

Can you reply to this issue with the Wireframes (for this specific case).

I am also queueing this in Sprint 20, as @urmauur may be able to get to it next week.

@imtuyethan imtuyethan added this to the v0.5.5 milestone Sep 12, 2024
@imtuyethan
Copy link
Contributor Author

imtuyethan commented Sep 12, 2024

Archive Original Issue

### Case 1: Users delete model of a thread
In this scenario, a user has deleted or removed the specific model associated with an existing conversation thread. The interface shows:
- The model dropdown now displays "Mistral Instruct 7B Q4" but is grayed out, indicating it's no longer available
- An error message in the chat area states "Current model is not available. Please download or choose a different one."

![Screenshot 2024-09-09 at 9 44 40 AM](https://github.com/user-attachments/assets/b8d5aaa3-34f5-4c02-a9c2-75896fdbabfd)
https://www.figma.com/design/DYfpMhf8qiSReKvYooBgDV/Jan-App-(3rd-version)?node-id=8322-71957&t=EerQsMye51GlIUlB-4

### Case 2: Users delete all models or API key but continue using old threads
In this case, the user has deleted all local models or removed their API key, but is attempting to continue using existing conversation threads. The interface shows:
- The model dropdown displays "Select a model" with no options available
- An error message in the chat area states "You don't have any available model." with a "Go to Hub" button

![Screenshot 2024-09-09 at 9 47 03 AM](https://github.com/user-attachments/assets/f7e99713-f7c0-46fd-9fd8-b833c681bef2)
https://www.figma.com/design/DYfpMhf8qiSReKvYooBgDV/Jan-App-(3rd-version)?node-id=8124-71826&t=EerQsMye51GlIUlB-4

@imtuyethan imtuyethan removed their assignment Sep 12, 2024
@imtuyethan imtuyethan added type: enhancement Improves a current feature P1: important Important feature / fix and removed type: feature request A new feature labels Sep 12, 2024
@imtuyethan
Copy link
Contributor Author

^ Updated the description with new design @dan-homebrew

@imtuyethan imtuyethan assigned imtuyethan and unassigned urmauur Sep 13, 2024
@dan-homebrew
Copy link
Contributor

dan-homebrew commented Sep 16, 2024

@imtuyethan Quick feedback:

Is there a visual indicator we can use to prompt user that they need to change the model?

  • Currently, it's greyed out, with the old model name
  • Grey out = won't user think it's disabled?
  • Should we draw their attention to the thing that needs changing, e.g. with a glow around the model selector?

I also think we can simplify the copywriting for the error message:

image

@imtuyethan
Copy link
Contributor Author

imtuyethan commented Sep 17, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: threads & chat Threads & chat UI UX issues needs designs Needs designs P1: important Important feature / fix type: enhancement Improves a current feature
Projects
Status: Planning
Development

No branches or pull requests

5 participants