Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: stdout "loading model..." during run and start #801

Closed
0xSage opened this issue Jul 1, 2024 · 0 comments · Fixed by #818
Closed

feat: stdout "loading model..." during run and start #801

0xSage opened this issue Jul 1, 2024 · 0 comments · Fixed by #818
Assignees
@louis-jan
Labels
good first issue Good for newcomers P1: important Important feature / fix type: feature request A new feature

Comments

@0xSage
Copy link
Contributor

0xSage commented Jul 1, 2024

When running any model, it takes a while to load model. It looks like the command didn't work, leading users to ctrl-c or be confused. We should stdout a transition message like “loading model...”
@0xSage 0xSage added type: feature request A new feature P1: important Important feature / fix labels Jul 1, 2024
@0xSage 0xSage added the good first issue Good for newcomers label Jul 1, 2024
@0xSage 0xSage changed the title feat: stdout "loading model" during run and start feat: stdout "loading model..." during run and start Jul 1, 2024
@louis-jan louis-jan mentioned this issue Jul 3, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@louis-jan louis-jan

Labels
good first issue Good for newcomers P1: important Important feature / fix type: feature request A new feature
Projects
Jan & Cortex
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: error output logs for cortex run janhq/cortex.cpp
2 participants
@0xSage @louis-jan