Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gui/plotxy: opacity on even y axis ticks #58

Closed
sophiekovalevsky opened this issue Oct 17, 2021 · 7 comments
Closed

gui/plotxy: opacity on even y axis ticks #58

sophiekovalevsky opened this issue Oct 17, 2021 · 7 comments

Comments

@sophiekovalevsky
Copy link
Contributor

What if we can add an option to set an opacity for all even y axis ticks when using plots in xy, turning into something like this:

image

If someone just doesn't want this feature it all I can add an option to disable it on preferences -> graphs menu if that make sense.

@sophiekovalevsky
Copy link
Contributor Author

I forgot to mention that I would be happy to incorporate this feature by myself.

@jankae
Copy link
Owner

jankae commented Oct 17, 2021

This could certainly be useful. Maybe add the option for a different color instead of opacity? I could imagine that opacity does not work well for certain background colors (e.g. white).

@sophiekovalevsky
Copy link
Contributor Author

@jankae i ran several tests and I guess that if we don't set opacity would be more difficult for user to select the right color so it can combined at same time with actual background. On the other side, if I set the opacity with a different color, what I will get won't be exactly the color I think would be, that's the downside.

I set plotAreaTop variable because I will work this week on the other implementation and for that I think we need to set an offset on plot so traces background don't overlap with the actual start of plot.

@sophiekovalevsky
Copy link
Contributor Author

@jankae just found out a bug in my implementation, I will fix it soon and let you know when you are actually review it. Thanks.

@sophiekovalevsky
Copy link
Contributor Author

I think I fixed the issue. I revert the opacity feature since when viewing trace in auto-mode it seems like ticks width are not evenly spaced which completely disappears if opacity is disabled.

@jankae
Copy link
Owner

jankae commented Oct 25, 2021

I still had some issues on my system with the X axis ticks not being visible everywhere, because the second background color was drawing over them, but that was a simple fix by just moving around some lines of code, looks good to me now. I also changed the default value to better match the default of black for the "normal" background, I hope you don't mind

@sophiekovalevsky
Copy link
Contributor Author

I didn't noticed this and thanks for fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants