Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify if ByteBuffer should be used everywhere #53

Closed
jankotek opened this issue Mar 19, 2012 · 1 comment
Closed

Verify if ByteBuffer should be used everywhere #53

jankotek opened this issue Mar 19, 2012 · 1 comment

Comments

@jankotek
Copy link
Owner

With mapped ByteBuffer we could avoid some byte[] copying and improve performance. So we need to verify if using ByteBuffer all the way to DataInputOutput actually improves performance.

@jankotek
Copy link
Owner Author

No, it should not. Direct buffers are much slower for incremental writes than heap buffers. Bulk byte[] copy is fine. Rewriting core would not bring much performance gain

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant