Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set python_requires in setup.py #6

Closed
jankrepl opened this issue Sep 19, 2019 · 3 comments
Closed

Set python_requires in setup.py #6

jankrepl opened this issue Sep 19, 2019 · 3 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@jankrepl
Copy link
Owner

So that it is not even possible to install on unsupported versions of Python

@jankrepl jankrepl self-assigned this Sep 19, 2019
@jankrepl jankrepl added enhancement New feature or request good first issue Good for newcomers labels Oct 3, 2019
@fgriberi
Copy link
Contributor

fgriberi commented Oct 7, 2019

Hi guys, @jankrepl can I take this issue? My idea is adding a requirements folder with different files according each environment, for example, dev.txt and test.txt. Any suggestion is welcome

@jankrepl
Copy link
Owner Author

jankrepl commented Oct 7, 2019

Hey, thanks for your interest!!

My idea was to add the python_requires entry to thesetup function of setup.py.

See link for details.

Currently the tests are run for python 3.5, 3.6 and 3.7 so I suggest something like python_requires='>=3.5'.

It is a oneliner.

The goal is to make sure that people with lower version of Python get an error right away after trying to pip install pychubby.

@fgriberi
Copy link
Contributor

fgriberi commented Oct 7, 2019

got it! @jankrepl I thought it was related to installation requirements. I'll take it :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants