Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor language issue in documentation #123

Closed
alexreg opened this issue Jun 2, 2022 · 3 comments
Closed

Minor language issue in documentation #123

alexreg opened this issue Jun 2, 2022 · 3 comments
Labels
documentation Improvements or additions to documentation

Comments

@alexreg
Copy link
Contributor

alexreg commented Jun 2, 2022

I just came across the following sentence.

In your IDE, you won’t see arguments that has to do with shell completion, because they are different in Click 7 and 8 (both supported by Cloup):

To fix the grammar, it should be be `that have to do with", though it still reads slightly awkwardly in my view. I think the following would be ideal.

In your IDE, you won’t see arguments relating to shell completion, since they are different in Click 7 and 8 (both supported by Cloup):

Of course, the choice is yours; I just wanted to point this out. :-)

@alexreg alexreg added the bug Something isn't working label Jun 2, 2022
@janluke janluke added documentation Improvements or additions to documentation and removed bug Something isn't working labels Jun 3, 2022
@janluke
Copy link
Owner

janluke commented Jun 3, 2022

Thanks for reporting :)

@janluke
Copy link
Owner

janluke commented Jun 3, 2022

Oh, it looks like I had already fixed it with "have to do" but I'm not sure if this expression is so common in English, so I'll change it to "relating to" as you suggested.

@janluke janluke closed this as completed in 5685d79 Jun 3, 2022
@alexreg
Copy link
Contributor Author

alexreg commented Jun 3, 2022

@janluke Sounds good. (Yeah, while it is certainly an idiom, it is mainly used in casual speech, and sounds a bit odd in this context... very subtle, I admit.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

No branches or pull requests

2 participants