Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Insert row_sep only in between the rows of a definition list #36

Closed
janluke opened this issue Jun 6, 2021 · 0 comments · Fixed by #42
Closed

Insert row_sep only in between the rows of a definition list #36

janluke opened this issue Jun 6, 2021 · 0 comments · Fixed by #42
Milestone
v0.9.0

Comments

@janluke
Copy link
Owner

janluke commented Jun 6, 2021 •
edited
Loading

Not after section description, not after last row.
@janluke janluke added this to the v0.9.0 milestone Jun 7, 2021
@janluke janluke changed the title Don't add row_sep to the last row Insert row_sep only between the rows of a definition list Jun 15, 2021
@janluke janluke changed the title Insert row_sep only between the rows of a definition list Insert row_sep only in between the rows of a definition list Jun 15, 2021
janluke added a commit that referenced this issue Jun 16, 2021
@janluke
Redesign row_sep
99767fe 
1. Set it to `None` by default and write a `\n` after it (closes #41).
2. Insert `row_sep` only in between rows (closes #36).
3. Define `SepGenerator` as a protocol and allow to pass a generator
   to `row_sep` (closes #39).
4. Implements the `Hline` SepGenerator.
5. Define a `RowSepPolicy` base class and implement it with `RowSepIf`
   (closes #37).
@janluke janluke mentioned this issue Jun 16, 2021
Merged
janluke added a commit that referenced this issue Jun 16, 2021
@janluke
Redesign row_sep (#42)
a519ec1 
Redesign row_sep

1. Set it to `None` by default and write a `\n` after it (closes #41).
2. Insert `row_sep` only in between rows (closes #36).
3. Define `SepGenerator` as a protocol and allow to pass a generator
   to `row_sep` (closes #39).
4. Implements the `Hline` SepGenerator.
5. Define a `RowSepPolicy` base class and implement it with `RowSepIf`
   (closes #37).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v0.9.0
Development

Successfully merging a pull request may close this issue.

Redesign row_sep janluke/cloup
1 participant
@janluke