Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to pass a function (width: int) -> str as row_sep #39

Closed
janluke opened this issue Jun 14, 2021 · 0 comments · Fixed by #42
Closed

Allow to pass a function (width: int) -> str as row_sep #39

janluke opened this issue Jun 14, 2021 · 0 comments · Fixed by #42
Labels
enhancement New feature or request
Milestone

Comments

@janluke
Copy link
Owner

janluke commented Jun 14, 2021

This:

@janluke janluke added the enhancement New feature or request label Jun 14, 2021
@janluke janluke added this to the v0.9.0 milestone Jun 14, 2021
janluke added a commit that referenced this issue Jun 16, 2021
1. Set it to `None` by default and write a `\n` after it (closes #41).
2. Insert `row_sep` only in between rows (closes #36).
3. Define `SepGenerator` as a protocol and allow to pass a generator
   to `row_sep` (closes #39).
4. Implements the `Hline` SepGenerator.
5. Define a `RowSepPolicy` base class and implement it with `RowSepIf`
   (closes #37).
janluke added a commit that referenced this issue Jun 16, 2021
Redesign row_sep

1. Set it to `None` by default and write a `\n` after it (closes #41).
2. Insert `row_sep` only in between rows (closes #36).
3. Define `SepGenerator` as a protocol and allow to pass a generator
   to `row_sep` (closes #39).
4. Implements the `Hline` SepGenerator.
5. Define a `RowSepPolicy` base class and implement it with `RowSepIf`
   (closes #37).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant