Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hardcoded values #1

Closed
m-shinder opened this issue Oct 22, 2020 · 1 comment
Closed

Hardcoded values #1

m-shinder opened this issue Oct 22, 2020 · 1 comment

Comments

@m-shinder
Copy link
Contributor

m-shinder commented Oct 22, 2020 •
edited
Loading

if you try run gamebox without installation, images will not be displayed. Because binary look for images in /usr/share/gamebox/images and without installation it does not exist. I suggest

  • create CONFIG.h which would contain string defines (ex. IMAGE_PATH)
  • add 'debug' make option which will compile project with gcc -DDEBUG
  • in code use #ifdef DEBUG to compile debug-specific stuff
    and example CONFIG.h:
    #ifdef DEBUG
    # define IMAGE_PATH "./images"
    #endif
    #ifndef DEBUG
    # define IMAGE_PATH "/usr/share/gamebox/images
    #endif

your repo have no contribution info or rules, so i open the issue to ask you about this idea
@JannikHv
Copy link
Owner

@m-shinder I assume this is obsolete by your recent pull request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@JannikHv @m-shinder