Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mempool summary: fee rate ranges are wrong #581

Open
pabpas opened this issue Oct 3, 2023 · 3 comments
Open

Mempool summary: fee rate ranges are wrong #581

pabpas opened this issue Oct 3, 2023 · 3 comments
Labels

Comments

@pabpas
Copy link

pabpas commented Oct 3, 2023

Describe the bug

Fee rates ranges in the mempool summary can't be right. In the Fee Rate Distribution section the average fee rate is higher than the fee rate range:

Fee Rate Avg Fee Rate(sat/vB)
[3 - 4) 13.92
[2 - 3) 9.22
[1 - 2) 5.30
[0 - 1) 1.26

This also affects Estimate Block Depth calculation.

Environment (please complete the following information):

  • Bitcoin Core /Satoshi:25.0.0/
  • NodeJS v18.15.0
  • Firefox
  • btc-rpc-explorer 3.4.0
  • Installation Method: npm

Additional context

https://bitcoinexplorer.org/mempool-summary

@pabpas pabpas added the bug label Oct 3, 2023
@Thierry61
Copy link
Contributor

If you divide Avg Fee Rate by 4 then the result lies within the fee rate range. I suppose this is related to the size vs weight definitions, possibly the buckets limits are expressed in sats/vB and the avg fee rates in sats/B (or the reverse, I confess this is unclear in my head).

I agree there is a problem because:

  • the 2 columns (FEE RATE and AVG FEE RATE) don’t have consistent units
  • the unit is not mentioned in FEE RATE column
  • the unit may be incorrect in AVG FEE RATE column

The solution could be to divide values in AVG FEE RATE column by 4 and add sat/vB unit in FEE RATE column. That way everything would be expressed in sat/vB. What do you think ?

@pabpas
Copy link
Author

pabpas commented Oct 4, 2023

The solution could be to divide values in AVG FEE RATE column by 4 and add sat/vB unit in FEE RATE column. That way everything would be expressed in sat/vB. What do you think ?

Having everything consistent and with commonly used units (sats/vB) sounds like a solution 👍 But I think it is FEE RATE that needs correction, AVG FEE RATES already shows the right sats/vB values. Also, the chart "Fee Rate Distribution" shows in the X axis the units for fee rate (sats/vB), and that seems to be definitely wrong.

@pjw65
Copy link

pjw65 commented Mar 31, 2024

Seems to be same as #416

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants