Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Usability improvements #1

Closed
5 tasks done
maroider opened this issue Sep 1, 2020 · 7 comments
Closed
5 tasks done

Usability improvements #1

maroider opened this issue Sep 1, 2020 · 7 comments

Comments

@maroider
Copy link
Contributor

maroider commented Sep 1, 2020

I really like what you've made, but there are a couple of features whose addition would make this application even better.

Navigation

  • Arrow key navigation on top of h j k l.
  • Closing context menus (likely with Esc).
  • Some indication that there are menus other than the currently displayed one.

Volume control

  • Manually inputting exact volume values.

Start-up

  • Better handling of PulseAudio starting after rsmixer has started.

On Arch Linux, the pulseaudio.service systemd unit is configured (by default) to be triggered by the pulseaudio.socket socket. This means that the PulseAudio server won't start before an application attempts to connect to the server.

One simple fix would be to display a message saying something to the effect of "Connecting to the PulseAudio server..." if the connection takes more than, say, 200 ms to establish.

@jantap
Copy link
Owner

jantap commented Dec 20, 2020

arrow key navigation - added default keybindings for that. On that note as well - I need to create a better documentation on how to add keybindings
closing context menus - done
The top bar is now Output / Input / Cards, with the one open being highlighted

input of exact volume values isn't done yet

Rsmixer now better handles pulseaudio starts/stops/restarts. The only bug is that when PA is off keybindings (including exiting the program) don't function properly. Will fix soon

sorry for long reponse time. Got really tired with the project after the last push to publish it for people

@maroider
Copy link
Contributor Author

sorry for long reponse time. Got really tired with the project after the last push to publish it for people

You're doing this if your own volition, likely in your free time.
You don't need to feel bad for taking however long you need to recharge.

@jantap
Copy link
Owner

jantap commented Dec 24, 2020

I've done some fixes for rsmixer to handle pulseaudio being off or crashing. Seems to be working for me, but since you've already brought that up, could you maybe test whether it works on your machine? Both in the scenario you mentioned and when pulseaudio just crashes when rsmixer is running. Thanks in advance

@maroider
Copy link
Contributor Author

I'll try to test it in the next couple of days.

@maroider
Copy link
Contributor Author

maroider commented Dec 31, 2020

Quitting while the PulseAudio server is off works fine, but there's this strange flickering that happens every time rsmixer tries to reconnect. It's almost as if you're pre-emptively drawing the normal UI and then clearing it once the connection fails.

Another thing I noticed is that certain volume levels don't always correspond to the same dB reading. Sometimes, 100% will result in a 0.00 dB reading, but after adjusting the volume away from 100% and back, the dB reading is 0.24 instead of 0.00. It's not a dealbreaker by any means, but it is annoying.

@jantap
Copy link
Owner

jantap commented Jan 2, 2021

Quitting while the PulseAudio server is off works fine, but there's this strange flickering that happens every time rsmixer tries to reconnect. It's almost as if you're pre-emptively drawing the normal UI and then clearing it once the connection fails.

That's totally possible, I cut corners a bit and redraw the whole screen every second (was a bit too eager to test - easy fix though)

Another thing I noticed is that certain volume levels don't always correspond to the same dB reading. Sometimes, 100% will result in a 0.00 dB reading, but after adjusting the volume away from 100% and back, the dB reading is 0.24 instead of 0.00. It's not a dealbreaker by any means, but it is annoying.

Never thought that this would be annoying to any one. The way rsmixer works is it calculates what 1% is and then adds/substracts it from what was there earlier. Again, easy fix and should be done in the next couple of days

@maroider
Copy link
Contributor Author

Welp. It has been a while since I last checked in on this issue (partly because I moved back to Windows for a while).

It seems like you've implemented all the features I asked for as of the latest release, so I'll go ahead and close this now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants