Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Banner message should be configurable #453

Closed
jayfray12 opened this issue Aug 24, 2023 · 4 comments
Closed

Banner message should be configurable #453

jayfray12 opened this issue Aug 24, 2023 · 4 comments
Labels
kind/bug Something isn't working status/triage

Comments

@jayfray12
Copy link
Contributor

Describe the bug

The banner message Welcome to Red Hat Developer Hub! on the main screen should be configurable. There doesn't seem to be a way to change it.

image

Versions of software used and environment

RHDH DP 0.1

@jayfray12 jayfray12 added kind/bug Something isn't working status/triage labels Aug 24, 2023
@tumido
Copy link
Member

tumido commented Aug 24, 2023

Same with showcase which is hardcoded to:
image

We should parametrize this line:

To use app.title from the config or something like that. Thoughts @sonyccd @christophe-f ?

@nickboldt
Copy link
Member

nickboldt commented Aug 24, 2023

is app.title used in other places? Right now downstream (for 0.2 and future) has just "Red Hat Developer Hub" as the app.title https://gitlab.cee.redhat.com/rhidp/cpaas-rhdh-hub/-/blob/rhdh-1.0-rhel-9/distgit/containers/rhdh-hub/app-config.production.yaml#L3

note that the https://github.com/janus-idp/rhdh/ repo is deprecated in favour of the gitlab repo above.

@christophe-f
Copy link
Contributor

Yes that would be great to parametize this. Could also add input parameters such as username

@rhdh-bot
Copy link
Collaborator

rhdh-bot commented Sep 3, 2024

This issue has been closed due to the fact that the Janus community is being sunset.

For future plugin issues, please use https://github.com/backstage/community-plugins/issues

For future showcase issues, please use https://issues.redhat.com/browse/RHIDP

For more information on the sunset, see:

https://janus-idp.io/blog/2024/07/05/future-of-janus-community
https://issues.redhat.com/browse/RHIDP-3690
https://issues.redhat.com/browse/RHIDP-1018

@rhdh-bot rhdh-bot closed this as completed Sep 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Something isn't working status/triage
Projects
None yet
Development

No branches or pull requests

5 participants