Skip to content
This repository has been archived by the owner on Feb 2, 2024. It is now read-only.

chore: update deps and add Chart.yaml metadata #49

Merged
merged 1 commit into from
May 2, 2023

Conversation

tumido
Copy link
Member

@tumido tumido commented Apr 28, 2023

Description of the change

Update backstage chart dependency. Notable changes:

  • adds/fixes support for extraDeploy

Update bitnami-common chart dependency. Mayor release change - affected feature (adds support for image.digest in addition to image.tag) is not used in this chart.

Adds additional metadata to better support ArtifactHub publishing and OpenShift Helm catalog publishing.

Existing or Associated Issue(s)

N/A

Additional Information

N/A

Checklist

  • Chart version bumped in Chart.yaml according to semver.
  • Variables are documented in the values.yaml and added to the README.md. The helm-docs utility can be used to generate the necessary content. Use helm-docs --dry-run to preview the content.
  • JSON Schema generated.
  • List tests pass for Chart using the Chart Testing tool and the ct lint command.

Signed-off-by: Tomas Coufal <tcoufal@redhat.com>
Copy link
Contributor

@sabre1041 sabre1041 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Though i really wish we kept the option to specify the backstage image via digest

@tumido
Copy link
Member Author

tumido commented May 2, 2023

@sabre1041 I think I've missread the diffs... bitnami/common major version bump is actually due to an opposite reason:

So.. the conclusion is that both tag and digest are supported and since v2.0.1 also backwards compatible. Current version is v2.2.5

@tumido tumido merged commit 5b45ad7 into janus-idp:main May 2, 2023
@tumido tumido deleted the update-deps branch May 2, 2023 11:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants