-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[bitnami/common] Digest/Tag new approach backward compatible #12029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Carlos Rodriguez Hernandez <carlosrh@vmware.com>
This was referenced Aug 23, 2022
This was referenced Aug 23, 2022
glad to see you reintroduced parts of #11844 :) |
rafariossaa
pushed a commit
to rafariossaa/charts
that referenced
this pull request
Sep 13, 2022
…#12029) Signed-off-by: Carlos Rodriguez Hernandez <carlosrh@vmware.com> Signed-off-by: Carlos Rodriguez Hernandez <carlosrh@vmware.com>
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current behavior
1.- Default values
2.- Setting the image.digest
3.- Removing the image.digest (old default)
Behavior with changes in this PR
1.- Default values
2.- Setting the image.digest
3.- Removing the image.digest (old default)
Note the difference in the third case. With the current approach (bitnami/common@2.0.0), when
image.digest
doesn't exist in the values.yaml it returnsimage: docker.io/bitnami/rabbitmq@<nil>
. With the changes in this PR (bitnami/common@2.0.1), when theimage.digest
doesn't exist in the values.yaml a valid image is returnedimage: docker.io/bitnami/rabbitmq:3.10.7-debian-11-r4
using theimage.tag
as usual.This is what it's behind the issue described at #12026
Once merged this PR, we should release a new version of the different Helm charts bundling bitnami/common@2.0.1