Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use an internal function for summary in summarySpectra and summaryPeaks #19

Closed
sgibb opened this issue Sep 9, 2017 · 1 comment
Closed

Use an internal function for summary in summarySpectra and summaryPeaks #19

sgibb opened this issue Sep 9, 2017 · 1 comment

Comments

@sgibb
Copy link
Contributor

sgibb commented Sep 9, 2017

summarySpectra and summaryPeaks are nearly identical. I would suggest to create an internal function that calculates the summary statistics for mass and intensity. This could be used in summarySpectra and summaryPeaks. The snr statistics could be easily cbinded to the out data.frame.
@Japal Japal mentioned this issue Sep 17, 2017
Closed
@Japal
Copy link
Owner

Japal commented Sep 17, 2017

The common stats are now computed in an internal function (.summaryStats) and syntax has been simplified.

@Japal Japal closed this as completed Sep 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@sgibb @Japal