Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove XML namespace filter when getting MAM prefs from server #571

Merged
merged 1 commit into from
Dec 4, 2015
Merged

Remove XML namespace filter when getting MAM prefs from server #571

merged 1 commit into from
Dec 4, 2015

Conversation

neurolit
Copy link
Contributor

@neurolit neurolit commented Dec 3, 2015

Some XMPP servers (e.g. Ejabberd) don't put any XML namespace when sending MAM preferences:

<iq xmlns="jabber:client" from="neurolit" to="neurolit/Jappix" id="64" type="result">
   <prefs default="roster">
      <always/>
      <never/>
   </prefs>
</iq>

Jappix filters this message out, whereas it should take it into account.

This PR takes care of this.

@valeriansaliou
Copy link
Member

That's non-compliant to the spec. But anyway, clients have to adapt in those cases. Thanks :)

valeriansaliou added a commit that referenced this pull request Dec 4, 2015
@valeriansaliou
Merge pull request #571 from neurolit/mam-prefs-without-xmlns
04d426b 
Remove XML namespace filter when getting MAM prefs from server
@valeriansaliou valeriansaliou merged commit 04d426b into jappix:master Dec 4, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@neurolit @valeriansaliou