Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mypy failing again #667

Closed
jaraco opened this issue Feb 27, 2024 · 2 comments
Closed

mypy failing again #667

jaraco opened this issue Feb 27, 2024 · 2 comments

Comments

@jaraco
Copy link
Owner

jaraco commented Feb 27, 2024

Recent releases of mypy have created new failures:

_______________________________________________________ keyring/backends/SecretService.py ________________________________________________________
33: error: Signature of "priority" incompatible with supertype "KeyringBackend"  [override]
33: note:      Superclass:
33: note:          classproperty[int | float]
33: note:      Subclass:
33: note:          classproperty[int]
__________________________________________________________ keyring/backends/Windows.py ___________________________________________________________
84: error: Signature of "priority" incompatible with supertype "KeyringBackend"  [override]
84: note:      Superclass:
84: note:          classproperty[int | float]
84: note:      Subclass:
84: note:          classproperty[int]
__________________________________________________________ keyring/backends/chainer.py ___________________________________________________________
22: error: Signature of "priority" incompatible with supertype "KeyringBackend"  [override]
22: note:      Superclass:
22: note:          classproperty[int | float]
22: note:      Subclass:
22: note:          classproperty[int]
____________________________________________________________ keyring/backends/fail.py ____________________________________________________________
18: error: Signature of "priority" incompatible with supertype "KeyringBackend"  [override]
18: note:      Superclass:
18: note:          classproperty[int | float]
18: note:      Subclass:
18: note:          classproperty[int]
____________________________________________________________ keyring/backends/null.py ____________________________________________________________
14: error: Signature of "priority" incompatible with supertype "KeyringBackend"  [override]
14: note:      Superclass:
14: note:          classproperty[int | float]
14: note:      Subclass:
14: note:          classproperty[int]
@jaraco
Copy link
Owner Author

jaraco commented Feb 27, 2024

These errors don't make sense to me. If a subclass returns a subset of types supported by the superclass, that's still compatible. shrug

@jaraco jaraco closed this as completed in c7d3d59 Feb 27, 2024
@jaraco
Copy link
Owner Author

jaraco commented Feb 27, 2024

I welcome others to raise this seemingly false positive with the mypy project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant