Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error handling in Side Effects might be broken #83

Open
jared-dykstra opened this issue Jan 25, 2019 · 2 comments
Open

Error handling in Side Effects might be broken #83

jared-dykstra opened this issue Jan 25, 2019 · 2 comments

Comments

@jared-dykstra
Copy link
Owner

Need to test and ensure:
@jared-dykstra jared-dykstra added the bug Something isn't working label Jan 25, 2019
@jared-dykstra
Copy link
Owner Author

I noticed that logPageView() appears to be blocking rendering--the whole point of the saga was to no block. (Or switch to react hooks)

@jared-dykstra jared-dykstra removed the bug Something isn't working label Jan 25, 2019
@jared-dykstra
Copy link
Owner Author

I think everything is ok. It would just be nice to prove it with tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@jared-dykstra