Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Public dependency bumped to semver-incompatible version in non-major version of this crate #38

Closed
CobaltCause opened this issue Apr 18, 2024 · 2 comments

Comments

@CobaltCause
Copy link

CobaltCause commented Apr 18, 2024

This problem was discovered by @Lymkwi.

webp bumped its dependency on image from ^0.24 to ^0.25, which are semver incompatible releases, and it did so in a semver compatible release of webp from 0.2.6 to 0.2.7, which is incorrect. Bumping the version of a public dependency to a semver-incompatible version is a breaking change and should be reflected in the versioning of this crate.

I imagine a fix for this problem would be to yank 0.2.7 of webp and rerelease it as 0.3.0.

@Lymkwi
Copy link

Lymkwi commented Apr 18, 2024

For additional context, i encountered this issue while running cargo install --git https://github.com/getzola/zola --tag v0.18.0, which uses webp = "0.2" as dependency; because there was no bump in the minor version number, their builds suddenly break if you remove the lock file (or ignore it as cargo build does by default).

@jaredforth
Copy link
Owner

I imagine a fix for this problem would be to yank 0.2.7 of webp and rerelease it as 0.3.0

Good find! Working on this now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants