Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a container factory rather than an immediate global container #13

Open
neverfox opened this issue Dec 13, 2014 · 1 comment
Open

Comments

@neverfox
Copy link

I've been running into an issue with electrolyte where the fact that it operates as a global container (cached by node once required) makes it problematic to use when you have one electrolyte project using another electrolyte library as a dependency (since node doesn't guarantee that your dependency won't just use a higher level electrolyte in node_modules). So I get collisions on component names, which silently override the earlier ones. It also makes testing harder because I cannot create isolated containers for a given test suite.

@jsumners
Copy link

I think being able to add a namespace to the container would solve the problem. Maybe when you require Electrolyte you could specify the name of the container you want to retrieve?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants