Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When express app is mounted at non-root endpoint, passport-http returns 400 #43

Open
adborden opened this issue Nov 30, 2014 · 4 comments · May be fixed by #44 or #72
Open

When express app is mounted at non-root endpoint, passport-http returns 400 #43

adborden opened this issue Nov 30, 2014 · 4 comments · May be fixed by #44 or #72

Comments

@adborden
Copy link

Mounting an app at a non-root endpoint fails on the uri check because passport-http is only checking the relative uri as seen by the express app, not by the uri as seen by the client.
e.g.

authApp = require('../modules/auth');
app.use('/auth', authApp);

// ../module/auth.js
app.get('/digest', passport.authenticate 'digest');

Seems to always yield 400.

@mauron85
Copy link

+1

1 similar comment
@fchu
Copy link

fchu commented Sep 25, 2017

+1

@fchu
Copy link

fchu commented Sep 25, 2017

Uh sorry just saw there was already a pull request!
@jaredhanson please accept either fix :)

@libinvarghese
Copy link

@jaredhanson Any update on merge? #44 works for me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants