Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added explicit return type for the hooks that return tuples #3189

Open
wants to merge 2 commits into
base: next
Choose a base branch
from

Conversation

behzadmehrabi
Copy link

@behzadmehrabi behzadmehrabi commented May 10, 2021

addresses issue #3144.

I'm not sure whether it's a good idea to remove passing types to useFormikContextSelector and let them be any type since hooks now have an explicit return type(it would make the code cleaner) or not, what do you think?

@changeset-bot
Copy link

changeset-bot bot commented May 10, 2021

⚠️ No Changeset found

Latest commit: 39067f1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented May 10, 2021

@Bezmehrabi is attempting to deploy a commit to the Formium Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions
Copy link
Contributor

This pull request is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 60 days

@github-actions github-actions bot added the stale label Jun 10, 2021
@johnrom johnrom removed the stale label Jun 10, 2021
@github-actions
Copy link
Contributor

This pull request is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 60 days

@github-actions github-actions bot added the stale label Jul 11, 2021
@johnrom johnrom removed the stale label Jul 12, 2021
@github-actions
Copy link
Contributor

This pull request is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 60 days

@github-actions github-actions bot added the stale label Aug 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants