Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Explicit Return Types to v3 #3144

Closed
johnrom opened this issue Apr 9, 2021 · 6 comments
Closed

Add Explicit Return Types to v3 #3144

johnrom opened this issue Apr 9, 2021 · 6 comments

Comments

@johnrom
Copy link
Collaborator

johnrom commented Apr 9, 2021

#2846 (comment)

@johnrom johnrom added this to the v3.0 milestone Apr 9, 2021
@johnrom johnrom changed the title Add Explicit Return Types Add Explicit Return Types to v3 Apr 9, 2021
@johnrom johnrom mentioned this issue Apr 9, 2021
1 task
@github-actions
Copy link
Contributor

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 60 days

@github-actions
Copy link
Contributor

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 60 days

@github-actions github-actions bot added the stale label Jun 10, 2021
@johnrom johnrom removed the stale label Jun 10, 2021
@github-actions
Copy link
Contributor

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 60 days

@github-actions github-actions bot added the stale label Jul 11, 2021
@johnrom johnrom removed the stale label Jul 12, 2021
@github-actions
Copy link
Contributor

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 60 days

@github-actions github-actions bot added the stale label Aug 12, 2021
@dantman
Copy link

dantman commented Oct 27, 2021

I did a check over your v3 branch. Your use* state hooks don't use the [value, setValue] style of tuple that makes explicit return types mandatory.

So this isn't necessary to make hooks function, like it was for the original v3.

The TypeScript compilation process also outputs explicit types in the .d.ts so it's also not important for TypeScript performance.

@johnrom
Copy link
Collaborator Author

johnrom commented Oct 28, 2021

There were a few that did, like useFormikState, but I kept this in mind while building it.

Thanks for checking it out; I'll close this one.

@johnrom johnrom closed this as completed Oct 28, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants