Formik v3 Umbrella PR. #3231

johnrom · 2021-06-04T19:48:56Z

Note: Formik no longer appears maintained, but I am leaving this PR open for archival purposes.

closes #3099

Todo:

Merge main
React Native Batching
Documentation

Added Ref State. Added useSelectorComparer. Starting to build subscriptions.

…ohnrom/subscriber

use-subscriptions might not work in React 17? Seems returning the previous value doesn't bail out the render.

Sync up formik-native and formik for v3.

…n package.

…seIsValid

…te will do. If we call our own reducer then use useReducer dispatch, `state.values !== getState().values`.

…ormikReducerState + FormikComputedState. Add Fixtures and Tutorial code to /app.

Consolidate State and Add Tutorial + Fixtures.

For some reason, the tests for remove only worked when they were async or render was moved from beforeEach to the individual tests.

Add missing useIsValidating hook

kuzaxak · 2022-01-23T23:52:33Z

Hi, do you have any plans with that v3 version? Or maybe you need some help?

We would like to use v3 in our application and try to figure out what is the best way to do so.

johnrom · 2022-01-24T15:23:38Z

@kuzaxak this PR is complete as far as I know. I requested Formik release it as an official RC so it can get more testing done, but there has been no movement there. Unfortunately I'm fully loaded up on client work at the moment, so I haven't decided where to go next.

jonstuebe · 2022-01-24T16:49:38Z

Would love to see the RC published! I have a decent size monorepo that I can help test things on and give feedback on perf and such.

kuzaxak · 2022-01-24T17:37:21Z

@kuzaxak this PR is complete as far as I know. I requested Formik release it as an official RC so it can get more testing done, but there has been no movement there. Unfortunately I'm fully loaded up on client work at the moment, so I haven't decided where to go next.

I see that you published it as rc under your own npm package, can we use it? Or we need to use git dependency?

johnrom · 2022-01-24T17:56:37Z

Feel free to test my RC via npm with @johnrom/formik-v3@3.0.0-rc1 in order to test and add any issues you may find here, with the following caveats:

I will not be providing support to individuals for my RC; any issues you find may or may not be resolved in a timely fashion.
Some things are not very well-documented and I probably won't find too much time to answer questions either. The API should be backwards compatible with Formik for the most part with some minor variations (useFormikState, useFormikContext and useFormikConfig have been split). You'll probably need to run through this PR and find subtle differences on your own. The Types will help to identify where pieces of Formik come from in the new system. The helper components like Formik, Form, Field, and ErrorMessage should work just as they did before.
- for your convenience, here are the docs that I started for my RC. unfortunately, I haven't had time to work on them, but all of the examples have been updated in the code. v3 docs johnrom/formik#11
The current npm package is a placeholder because I wanted to make it clear that it's not meant to be a production version. If it were eventually released you'd have to switch back to the final released package.
I am not a maintainer of Formik so this PR should not be a general issue repository for Formik itself, only issues with the specific changes made to this PR.

kuzaxak · 2022-01-24T18:04:01Z

Feel free to test my RC via npm with @johnrom/formik-v3@3.0.0-rc1 in order to test and add any issues you may find here, with the following caveats:

I will not be providing support to individuals for my RC; any issues you find may or may not be resolved in a timely fashion.

Some things are not very well-documented and I probably won't find too much time to answer questions either. The API should be backwards compatible with Formik for the most part with some minor variations (useFormikState, useFormikContext and useFormikConfig have been split). You'll probably need to run through this PR and find subtle differences on your own. The Types will help to identify where pieces of Formik come from in the new system. The helper components like Formik, Form, Field, and ErrorMessage should work just as they did before.

for your convenience, here are the docs that I started for my RC. unfortunately, I haven't had time to work on them, but all of the examples have been updated in the code. v3 docs johnrom/formik#10

The current npm package is a placeholder because I wanted to make it clear that it's not meant to be a production version. If it were eventually released you'd have to switch back to the final released package.

I am not a maintainer of Formik so this PR should not be a general issue repository for Formik itself, only issues with the specific changes made to this PR.

This is totally understandable :)

If we will find some problems we always can fork your fork and propose a change.
Thank you for your answers and the work you did!

johnrom · 2022-01-24T18:12:02Z

I updated my previous comment to use the correct PR for the documentation. The previous one was the wrong branch. The new PR is here: johnrom#11

Mikoz93 · 2022-01-29T00:35:48Z

@jaredpalmer Is there any plan to move this forward? It seems like from the original Todo's, only the documentation remains to be complete. Thanks for your time!

adam-thomas-privitar · 2022-03-31T17:05:22Z

@johnrom Just letting you know the published @johnrom/formik-v3@3.0.0-rc1 package has an incorrect module field in package.json.

Im having trouble using this in place of my existing installation, since useSetFieldValue is not exported. I think probably cos my project is based on top of the beta in main, this isnt reflected in this PR?

johnrom · 2022-03-31T17:15:03Z

@adam-thomas-privitar you don't have to use the micro-hooks, you can use useFormikContext().setFieldValue.

The micro-hooks are from the original v3 PR Jared created which optimized the hooks a different way. This one instead removes state from useFormikContext which makes it a stable hook which will not trigger re-renders.

I'll take a look at the package.json when I get a chance.

johnrom · 2022-03-31T18:08:15Z

The module issue should be fixed in 3.0.0-rc2.

With the updated module, you can do this after node modules are installed:

import { useField } from '@johnrom/formik-v3';

const MyField = (props) => {
  const [field] = useField(props);

  return <input {...field} />;
}

adam-thomas-privitar · 2022-04-01T21:02:00Z

@adam-thomas-privitar you don't have to use the micro-hooks, you can use useFormikContext().setFieldValue.

The micro-hooks are from the original v3 PR Jared created which optimized the hooks a different way. This one instead removes state from useFormikContext which makes it a stable hook which will not trigger re-renders.

I'll take a look at the package.json when I get a chance.

Yeh I suspected as much! Sadly...Im based on the v3 beta and so have a fair amount of code on top of the "new" hooks. I will need to do a bit more refactoring.

Thanks for fixing the module issue.

… handled anyway. We'd want to dispatch a request to validate specific fields which can be cancelled as more validations are requested.

vercel · 2022-04-15T20:56:46Z

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployments, click below or on the icon next to each commit.

formik-docs – ./

🔍 Inspect: https://vercel.com/jared/formik-docs/2LvHDxC73yoFJbQhSLohVRBq3oDr
✅ Preview: Failed

leoriviera · 2024-04-29T12:20:26Z

@quantizor, noticed you approved a PR for a release that went out a few days ago. This might be great to consider approving, as I've run into #3335 myself! I'm happy to make any changes necessary to resolve any merge conflicts.

johnrom and others added 30 commits March 8, 2021 18:28

Started to reimplement subscriber.

9f8765e

Added Ref State. Added useSelectorComparer. Starting to build subscriptions.

Grab types from other PR, to simplify later.

4dc160b

Grab types from other PR, to simplify later.

ef66e38

Merge branch 'johnrom/subscriber' of github.com:johnrom/formik into j…

b77d371

…ohnrom/subscriber

Set up dev environment and implement Field.

3e6e20c

use-subscriptions might not work in React 17? Seems returning the previous value doesn't bail out the render.

Memoize Formik API and make it rain optimized states.

881d7e6

Sync up formik-native and formik for v3.

Roll back unnecessary tsconfig change.

b8e7fcd

Fix Sign In App Page.

feaee0e

Roll back unnecessary tsconfig change.

a5a2f47

Wire up FormikConsumer.

4037473

Remove implementation details from deprecated comments.

e2c496c

Don't expose internal useOptimizedSelector.

a78459b

Reduce maintenance surface by moving useOptimizedSelector into its ow…

747ce07

…n package.

Update use-optimized-selector

9d10f82

Move useFormikComputedState to api.useComputedState, useIsDirty and u…

0d1cbfd

…seIsValid

Accidental import change.

0c18ebb

Remove TSConfig path aliases during build.

3ab46cd

If we're calling our own reducer, we don't need to useReducer! setSta…

5011168

…te will do. If we call our own reducer then use useReducer dispatch, `state.values !== getState().values`.

Optimize field meta and computed state with shallow equals.

a5f4643

Move Computed State into normal state helpers so that FormikState = F…

c9b9579

…ormikReducerState + FormikComputedState. Add Fixtures and Tutorial code to /app.

Merge pull request #3 from jawnstreams/johnrom/downstream

611432a

Consolidate State and Add Tutorial + Fixtures.

Clarify RenderState vs GetState. Fix Test.

dc2e2fa

Fix tests with updated /app structure.

0764e12

Remove unused helper components from app/

0079948

Ignore TypeScript Build Errors during app/ build.

9c4cd01

Add Changeset

ba1fdb9

Add Parse / Format to Subscriptions PR

e800bf8

Add changes from FieldArray over reducer-refs PR.

c06dff8

For some reason, the tests for remove only worked when they were async or render was moved from beforeEach to the individual tests.

Add Field Array to App Index

ba6f6c0

Fix UseField type definition, add micro-hooks.

70de3d1

dantman and others added 2 commits October 27, 2021 13:21

Add missing useIsValidating hook

45e28c6

Merge pull request #9 from dantman/johnrom-v3-isvalidating

a38ded4

Add missing useIsValidating hook

This was referenced Nov 2, 2021

setValues retrieves old state in the function variant #3047

Open

Performance wise Formik not good #3400

Open

This was referenced Nov 15, 2021

onChange for entire form #271

Closed

Main tutorial is confusing and some parts are broken (getFieldProps) #2511

Open

This was referenced Nov 29, 2021

No onChange prop for <Formik/>? #1633

Open

updates during validation on unmounted component #3418

Open

Repository owner deleted a comment from picosam Dec 10, 2021

johnrom mentioned this pull request Dec 13, 2021

Bad Performance on Large Forms (FastField Rerendering when it Shouldn't Be) #2335

Open

johnrom mentioned this pull request Feb 10, 2022

[V2] useFormikContext doesn't return valitationSchema as expected #2092

Open

johnrom mentioned this pull request Apr 12, 2022

Concurrent calls to setFieldValue results in field validator receiving stale value #3542

Open

Remove field from form-level validations. This isn't how it should be…

f899b89

… handled anyway. We'd want to dispatch a request to validate specific fields which can be cancelled as more validations are requested.

vercel bot had a problem deploying to Preview – formik-docs April 15, 2022 20:56 Failure

david-crespo mentioned this pull request Apr 16, 2022

Switch to React Hook Form oxidecomputer/console#804

Closed

Zikoat mentioned this pull request Dec 14, 2023

Add correct types for Field #3927

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Formik v3 Umbrella PR. #3231

Formik v3 Umbrella PR. #3231

johnrom commented Jun 4, 2021 •

edited

Loading

kuzaxak commented Jan 23, 2022

johnrom commented Jan 24, 2022

jonstuebe commented Jan 24, 2022

kuzaxak commented Jan 24, 2022

johnrom commented Jan 24, 2022 •

edited

Loading

kuzaxak commented Jan 24, 2022 •

edited

Loading

johnrom commented Jan 24, 2022

Mikoz93 commented Jan 29, 2022

adam-thomas-privitar commented Mar 31, 2022 •

edited

Loading

johnrom commented Mar 31, 2022 •

edited

Loading

johnrom commented Mar 31, 2022 •

edited

Loading

adam-thomas-privitar commented Apr 1, 2022 •

edited

Loading

vercel bot commented Apr 15, 2022 •

edited

Loading

leoriviera commented Apr 29, 2024 •

edited

Loading

Formik v3 Umbrella PR. #3231

Are you sure you want to change the base?

Formik v3 Umbrella PR. #3231

Conversation

johnrom commented Jun 4, 2021 • edited Loading

kuzaxak commented Jan 23, 2022

johnrom commented Jan 24, 2022

jonstuebe commented Jan 24, 2022

kuzaxak commented Jan 24, 2022

johnrom commented Jan 24, 2022 • edited Loading

kuzaxak commented Jan 24, 2022 • edited Loading

johnrom commented Jan 24, 2022

Mikoz93 commented Jan 29, 2022

adam-thomas-privitar commented Mar 31, 2022 • edited Loading

johnrom commented Mar 31, 2022 • edited Loading

johnrom commented Mar 31, 2022 • edited Loading

adam-thomas-privitar commented Apr 1, 2022 • edited Loading

vercel bot commented Apr 15, 2022 • edited Loading

formik-docs – ./

leoriviera commented Apr 29, 2024 • edited Loading

johnrom commented Jun 4, 2021 •

edited

Loading

johnrom commented Jan 24, 2022 •

edited

Loading

kuzaxak commented Jan 24, 2022 •

edited

Loading

adam-thomas-privitar commented Mar 31, 2022 •

edited

Loading

johnrom commented Mar 31, 2022 •

edited

Loading

johnrom commented Mar 31, 2022 •

edited

Loading

adam-thomas-privitar commented Apr 1, 2022 •

edited

Loading

vercel bot commented Apr 15, 2022 •

edited

Loading

leoriviera commented Apr 29, 2024 •

edited

Loading