Add missing dependency @types/hoist-non-react-statics, closes #3837

[patik]

This package is needed by Formik but it was not included in the dependency list.

Fixes #3837

[changeset-bot]

🦋 Changeset detected

Latest commit: 6da4ec4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages

Name	Type
formik	Patch
formik-native	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
formik-docs	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Sep 17, 2023 7:45pm

[codesandbox-ci]

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 6da4ec4:

Sandbox	Source
Formik TypeScript Playground (forked)	Configuration

[quantizor]

Thank you

[quantizor]

Could you add a changeset please?

[quantizor]

Actually sorry, I think this type needs to go in formik's specific package.json not the top one?

[patik]

Actually sorry, I think this type needs to go in formik's specific package.json not the top one?

Do you mean packages/formik/package.json? This dependency is already listed in that package (it's been there for at least 4 years), but the issue seems to persist unless the dependency is in the root-level package.json.

[quantizor]

Actually sorry, I think this type needs to go in formik's specific package.json not the top one?

Do you mean packages/formik/package.json? This dependency is already listed in that package (it's been there for at least 4 years), but the issue seems to persist unless the dependency is in the root-level package.json.

You're seeing that a dependency in a workspace package isn't installing downstream in your client package because it's not present in the workspace root package.json? That seems unlikely.

It's currently in devDependencies, perhaps move it to dependencies in that file?

[patik]

It's currently in devDependencies, perhaps move it to dependencies in that file?

Indeed, that change resolves the issue. I made the change, and now if I install Formik in another project, the @types/hoist-non-react-statics package is also installed, and the TS error goes away.

[quantizor]

Awesome, thank you :)

[quantizor]

Pinged Jared to fix the required check settings, please hold