Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Expand on cleanup behaviour for submission handlers #3876

Merged
merged 6 commits into from Sep 11, 2023
Merged

docs: Expand on cleanup behaviour for submission handlers #3876

merged 6 commits into from Sep 11, 2023

Conversation

Nessworthy
Copy link
Contributor

Cover use cases for both using a submission handler that returns a promise, and for a one which does not.

Add FAQ entry about submission handler cleanup.

Following submission handling logic from https://github.com/jaredpalmer/formik/blob/main/packages/formik/src/Formik.tsx#L754-L782

Cover use cases for both using a submission handler that returns a promise, and for a one which does not.

Add FAQ entry about submission handler cleanup.
@changeset-bot
Copy link

changeset-bot bot commented Sep 6, 2023

⚠️ No Changeset found

Latest commit: 2e597c8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Sep 6, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
formik-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 9, 2023 6:42pm

@codesandbox-ci
Copy link

codesandbox-ci bot commented Sep 6, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 2e597c8:

Sandbox Source
Formik TypeScript Playground (forked) Configuration

Wrap FAQ entry in `details correctly.

Remove use of inline code markers in `summary` as it seems like they are not supported.
Add spacing between lines to support proper inline code formatting.
@Nessworthy
Copy link
Contributor Author

Please squash if merged, do not immortalise my formatting mistakes 😂

Copy link
Collaborator

@quantizor quantizor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :)

@quantizor quantizor added the automerge automerge label for kodiak label Sep 8, 2023
@quantizor quantizor merged commit bbcbc59 into jaredpalmer:main Sep 11, 2023
8 checks passed
@Nessworthy Nessworthy deleted the patch-1 branch September 11, 2023 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge automerge label for kodiak
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants