Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #284 and #258 - Empty input type=number results in NaN #437

Merged
merged 1 commit into from
Feb 14, 2018

Conversation

victordidenko
Copy link
Contributor

Fixes issues #284 and #258, when emptying input with type="number" causes error "Received NaN for the value attribute. If this is expected, cast the value to a string."

@jaredpalmer jaredpalmer merged commit 017b739 into jaredpalmer:master Feb 14, 2018
@victordidenko
Copy link
Contributor Author

@jaredpalmer Thanks for quick response! Do you have plans to draft new release any time soon?

@jaredpalmer
Copy link
Owner

jaredpalmer commented Feb 15, 2018 via email

@strange-developer
Copy link

Great library. I've just run into the same issue as well. Do you have a rough estimate on when this fix will be published to NPM?

@victordidenko
Copy link
Contributor Author

🎉 as I see, new release has been drafted about three hours ago ^_^

@victordidenko victordidenko deleted the issue_258 branch February 21, 2018 19:40
@jaredpalmer
Copy link
Owner

Try 11.11.

@innerdaze
Copy link

I'm running 11.11 and still have this issue

@jaredpalmer
Copy link
Owner

hrm. so perhaps the fix did not work?

@innerdaze
Copy link

oh hang on... I'm using the component prop. if i leave that out then it works fine

@innerdaze
Copy link

Ok I fixed it my end - might be worth documenting that if you use a custom component then you need to add a special case for number fields

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants