-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #284 and #258 - Empty input type=number results in NaN #437
Conversation
@jaredpalmer Thanks for quick response! Do you have plans to draft new release any time soon? |
Yeah will cut one this morning
…--
Jared
________________________________
From: Victor Didenko <notifications@github.com>
Sent: Thursday, February 15, 2018 4:59:04 AM
To: jaredpalmer/formik
Cc: Jared Palmer; Mention
Subject: Re: [jaredpalmer/formik] Fix #284 and #258 - Empty input type=number results in NaN (#437)
@jaredpalmer<https://github.com/jaredpalmer> Thanks for quick response! Do you have plans to draft new release any time soon?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub<#437 (comment)>, or mute the thread<https://github.com/notifications/unsubscribe-auth/AD30GzILIRO3b9UUtPC9dn6S1f8TWGxCks5tU__ogaJpZM4SF-UQ>.
|
Great library. I've just run into the same issue as well. Do you have a rough estimate on when this fix will be published to NPM? |
🎉 as I see, new release has been drafted about three hours ago ^_^ |
Try 11.11. |
I'm running 11.11 and still have this issue |
hrm. so perhaps the fix did not work? |
oh hang on... I'm using the |
Ok I fixed it my end - might be worth documenting that if you use a custom component then you need to add a special case for number fields |
Fixes issues #284 and #258, when emptying input with type="number" causes error "Received NaN for the
value
attribute. If this is expected, cast the value to a string."