-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
handleChange bug for empty number values: parseFloat('') is null #258
Labels
Comments
cloud-walker
changed the title
parseFloat('') is null
handleChange bug for empty number values: Nov 17, 2017
parseFloat('') is null
cloud-walker
changed the title
handleChange bug for empty number values:
handleChange bug for empty number values: parseFloat('') is null
Nov 17, 2017
parseFloat('') is null
True true. |
Should this be |
Related issue: #284 Also, for checking the value, what about this?
|
Submit a PR and with this change and a test if you get a chance |
victordidenko
added a commit
to victordidenko/formik
that referenced
this issue
Feb 14, 2018
Didn't make test though... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Input type number will be cast to
null
when cleared, because of this:formik/src/formik.tsx
Line 389 in 61a0869
Demo with the latest version of formik: https://codesandbox.io/s/m7268r7xoy
The text was updated successfully, but these errors were encountered: