Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove duplicated interfaces #575

Merged

Conversation

ohbarye
Copy link

@ohbarye ohbarye commented Apr 10, 2018

Hello maintainers, thanks for the great library.

This PR removes some duplicated interfaces that I found while reading formik's code.

Those interfaces are added in #141 and still remains, but they exist in withFormik.ts as well.

export type CompositeComponent<P> =
| React.ComponentClass<P>
| React.StatelessComponent<P>;
export interface ComponentDecorator<TOwnProps, TMergedProps> {
(component: CompositeComponent<TMergedProps>): React.ComponentType<TOwnProps>;
}
export interface InferableComponentDecorator<TOwnProps> {
<T extends CompositeComponent<TOwnProps>>(component: T): T;
}

Those interfaces are added in
jaredpalmer#141 and still remains.
@jaredpalmer jaredpalmer merged commit b72382e into jaredpalmer:master Apr 10, 2018
@ohbarye ohbarye deleted the remove-duplicated-interfaces branch April 10, 2018 16:56
@ohbarye
Copy link
Author

ohbarye commented Apr 10, 2018

Thank you for your quick review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants