Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(fix): revert #130's breaking change of tsconfig options #415

Merged

Conversation

agilgur5
Copy link
Collaborator

@agilgur5 agilgur5 commented Jan 4, 2020

Fixes #413 . EDIT: Also fixes #412

Whether TS should transpile to target or Babel should is a good question to raise, but for now this just reverts the breaking change.
Should probably document in the README that tsconfig target is ignored and that users should use Babel's preset-env to configure the target instead.
Should also probably add more tests around this as bugs / breaking changes like this in TSDX's build output can have ripple-effects on libraries using it (vs. the other commands don't affect output, so the impact is limited to just library authors as opposed to library users).

- not sure why this change was made in that PR as it was unrelated to
  the rest, but it broke some things related to Babel usage and maybe
  other things
  - e.g. babel macros were not included per jaredpalmer#413
  - and it used `tslib` instead of adding babel helper functions

- add a comment of why it seems like the target is overriden to esnext
  - though I am not sure of the original reasoning, as it has existed
    since very early versions of TSDX, see jaredpalmer#130 comments
@agilgur5
Copy link
Collaborator Author

agilgur5 commented Jan 4, 2020

Another example of .d.ts missing in Ubuntu CI tests here -- see growing list in #403

@jaredpalmer
Copy link
Owner

I forgot why, but this is v important.

@jaredpalmer jaredpalmer merged commit 00f80ac into jaredpalmer:master Jan 5, 2020
@agilgur5
Copy link
Collaborator Author

agilgur5 commented Jan 29, 2020

Found #117, #102 (#101), and #111 that are all related to this.
Also possibly #345, but not sure about that one.

Per #117, sounds like the comment I left in the code, // TS -> esnext, then leave the rest to babel-preset-env, describes the original rationale accurately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Breaking change with tsdx 0.12.1 with Tailwind babel macro tslib should be put in dependencies
2 participants