Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(refactor): migrate all tests and test helper code to TS #649

Merged
merged 1 commit into from
Mar 28, 2020

Conversation

agilgur5
Copy link
Collaborator

  • woot, all TS now!

    • get that big blue line for language TS on GitHub haha
  • for the most part, not much more to do other than .js -> .ts

    • for the utils had to add some types around
  • also use ESM instead of CJS in tests and test helpers

    • require -> import
    • module.exports -> export
      • the indentation change here with utils/fixture made git treat
        it as a delete + new instead of a rename

This was, of course, done because #627 added lots of tests, and definitely not because TSDX became majority JavaScript after #627. This was definitely not because the majority JavaScript made TSDX classified as a "JavaScript" library
Screen Shot 2020-03-27 at 2 10 25 AM

(it actually wasn't, I always wanted to convert the tests to TS, especially after the addition of the grep helper with JSDoc types in #525 (later moved to #627 which got merged first). but I can't say that didn't increase priority 😉 ).

- woot, all TS now!
  - get that big blue line for language TS on GitHub haha

- for the most part, not much more to do other than .js -> .ts
  - for the utils had to add some types around

- also use ESM instead of CJS in tests and test helpers
  - require -> import
  - module.exports -> export
    - the indentation change here with utils/fixture made git treat
      it as a delete + new instead of a rename
Copy link
Collaborator Author

@agilgur5 agilgur5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Mostly just CJS -> ESM, very little code changed, and only in the utils, which for the most part, was just adding types to functions

@agilgur5
Copy link
Collaborator Author

Screen Shot 2020-03-29 at 12 05 33 AM
That's better. Although I still don't think it's totally accurate

paul-vd pushed a commit to EezyQuote/tsdx that referenced this pull request Dec 1, 2020
…#649)

- woot, all TS now!
  - get that big blue line for language TS on GitHub haha

- for the most part, not much more to do other than .js -> .ts
  - for the utils had to add some types around

- also use ESM instead of CJS in tests and test helpers
  - require -> import
  - module.exports -> export
    - the indentation change here with utils/fixture made git treat
      it as a delete + new instead of a rename
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant