Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore .size-snapshot.json #69

Closed
wants to merge 1 commit into from
Closed

Ignore .size-snapshot.json #69

wants to merge 1 commit into from

Conversation

mikl
Copy link

@mikl mikl commented May 1, 2019

This file is created by tsdx watch, and should probably not be tracked in git.

This file is created by `tsdx watc�h`, and should probably not be
tracked in git.
@erikras
Copy link

erikras commented May 1, 2019

It's tracked in Formik.

@mikl
Copy link
Author

mikl commented May 1, 2019

It might be worth tracking, but the one I get contains absolute paths (which will cause problems when multiple devs work on it), so I guess Formik has that configured differently, somehow?

Mine looks like:

{
  "/Users/mikl/Work/Node.js/edzif-validator/dist/edzif-validator.cjs.development.js": {
    "bundled": 125,
    "minified": 72,
    "gzipped": 86
  },
  "/Users/mikl/Work/Node.js/edzif-validator/dist/edzif-validator.cjs.production.js": {
    "bundled": 81,
    "minified": 50,
    "gzipped": 66
  },
  "/Users/mikl/Work/Node.js/edzif-validator/dist/edzif-validator.es.production.js": {
    "bundled": 63,
    "minified": 33,
    "gzipped": 52,
    "treeshaked": {
      "rollup": {
        "code": 0,
        "import_statements": 0
      },
      "webpack": {
        "code": 951
      }
    }
  },
  "/Users/mikl/Work/Node.js/edzif-validator/dist/edzif-validator.umd.development.js": {
    "bundled": 436,
    "minified": 250,
    "gzipped": 188
  },
  "/Users/mikl/Work/Node.js/edzif-validator/dist/edzif-validator.umd.production.js": {
    "bundled": 386,
    "minified": 228,
    "gzipped": 175
  }
}

@jaredpalmer
Copy link
Owner

@TrySound should this be tracked?

@TrySound
Copy link
Collaborator

TrySound commented May 2, 2019

It should be commited. @mikl Looks like a bug. I didn't see it before. Could you rise an issue in rollup-plugin-size-snapshot?

@TrySound
Copy link
Collaborator

TrySound commented May 3, 2019

@jaredpalmer I get it. tsdx passes resolved paths to output. And size snapshot put them without processing. Is it possible to pass relative paths to rollup config?

@jaredpalmer
Copy link
Owner

Probably.

@jaredpalmer
Copy link
Owner

Duplicate. Closing.

@jaredpalmer jaredpalmer closed this May 6, 2019
@TrySound
Copy link
Collaborator

@jaredpalmer I fixed this problem in rollup-plugin-size-snapshot v0.9

@agilgur5 agilgur5 added the scope: upstream Issue in upstream dependency label Mar 11, 2020
joeflateau pushed a commit to joeflateau/tsdx that referenced this pull request Nov 12, 2021
Squashed commits:
[412069f] docs: fix stroke-width => strokeWidth
[33f60c0] docs: update template/website documentation (jaredpalmer#73)
[544bbce] Delete documentation.yml
[b28416f] Revert "Documentation Fix (jaredpalmer#69)" (jaredpalmer#72)

This reverts commit d82864d.
[d82864d] Documentation Fix (jaredpalmer#69)

* 📖 Fixed documentation website

* working on Deployment errors

* switching to github pages

* test deploy
[8a4d3b3] Update documentation.yml (+1 squashed commit)
Squashed commits:
[99cc817] Create documentation.yml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope: upstream Issue in upstream dependency
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants