-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
delete does not return a promise #79
Comments
In what situation are you seeing this? |
An in-memory datastore. So something like: const CacheManager = require('cache-manager');
const cache = CacheManager.caching({store: 'memory'});
cache.set('foo', 1)
.then(() => cache.get('foo'))
.then((val) => console.log(val)) //1
.then(() => cache.del('foo'))
.then(() => cache.get('foo')) // throws an error. Expected a promise in return
.then((val) => console.log(val)) // expect undefined |
Thanks. I added a test for this and it passes for me. I also tried your exact example and it didn't throw an error. Here's the commit with the test: 04e6333 Can you check out the latest master branch and see if the tests pass for you? |
Seems to work. Still doesn't work in my specific case, but I suppose I'll assume id10t error, at this point. Thanks! |
No description provided.
The text was updated successfully, but these errors were encountered: