Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace ConfusedPolarBear's intro-skipper with jellyfin-plugin-media-analyzer #590

Closed
Meyu-Sys opened this issue Dec 8, 2023 · 6 comments
Labels
bug Something isn't working

Comments

@Meyu-Sys
Copy link

Meyu-Sys commented Dec 8, 2023

As the title says.
ConfusedPolarBear has archived intro-skipper and active development has ceased replace it with the most prominent fork jellyfin-plugin-media-analyzer made by endrl

@Meyu-Sys Meyu-Sys added the bug Something isn't working label Dec 8, 2023
@UriSheinman
Copy link

Is this plugin working for you? I'm genuinely curios cause I'm pretty savvy but I can't get it to work for the life of me. I think casual users will definitely have trouble adding this to their server while intro skip is still usable and working... I see the value of this plugin if it actually works...

@mihawk90
Copy link

IMO that plugin is not just a simple fork. While it relies on the same kind of detection it is an entirely different plugin. CPB's plugin was basically split in 4, it requires (at this time anyway) a patched version of Jellyfin until the media segments API is upstreamed, and it requires jellyfin-vue as a webinterface as well.
This is very much not intended for an enduser currently. It's for people that want to test cool new stuff that may or may not make it into Jellyfin eventually. It requires a lot of steps to even get working.

I agree that findroid should eventually transition to the media segments API, but I'd argue that only makes sense once the API is stable, i.e. in a Jellyfin release.

@AbandonedCart
Copy link

AbandonedCart commented Mar 3, 2024

Have you looked into https://github.com/jumoog/intro-skipper? I know this was posted a little while back, but I only arrived a few days ago.

You do not need a custom web player anymore. All you actually need is ffmpeg with Chromaprint (optional for better detection) and I believe Mac is the only one that doesn't include that natively already. They promised it would be in the next major release, though.

If you are a new user, Jellyfin Media Analyzer may be a bit more robust after you meet all of the requirements (media segments API and Vue player). They are only calling it a fork for the sake of tapping the user base, but it's a different direction with the same end result.

@Meyu-Sys
Copy link
Author

Meyu-Sys commented Mar 5, 2024

Endrl has made a pull request integrating some version of this plugin into the main jellyfin repo.
jellyfin/jellyfin#10530

@Meyu-Sys Meyu-Sys closed this as completed Mar 5, 2024
@AbandonedCart
Copy link

It's not a version of the plugin, only the API that is needed for Jellyfin Media Analyzer. You would still be missing the EDL creator, Jellyfin Segment Editor, and the actual Jellyfin Media Analyzer after that PR.

@mihawk90
Copy link

mihawk90 commented Mar 5, 2024

That PR was also already around when this Request was created (which I mentioned in my first reply).

Regardless, even once everything is upstreamed, it would still need work on Finamp to actually work with it, so I'm not sure why you'd close this issue as the original requester.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

4 participants