Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

with-channel without options doesn't work in 0.4.1 #18

Closed
weavejester opened this issue Jul 10, 2014 · 3 comments
Closed

with-channel without options doesn't work in 0.4.1 #18

weavejester opened this issue Jul 10, 2014 · 3 comments

Comments

@weavejester
Copy link
Contributor

There's a problem with the with-channel logic, specifically on lines 59 to 61:

        opts (when opts? opts)
        body (cond->> body
               (not opts?) (cons opts))

If opts? is false, then opts is bound to nil, and body is bound to (cons nil body).

To fix this, the opts rebinding should come after the body rebinding.

@jarohen
Copy link
Owner

jarohen commented Jul 10, 2014

Thanks James - I'll incorporate your fix when I get a moment. Failing that, if you've got a fork, could you submit a PR?

Cheers,

James

@weavejester
Copy link
Contributor Author

PR submitted (#19).

@jarohen
Copy link
Owner

jarohen commented Jul 10, 2014

Fixed in #19 (deployed as 0.4.2), thanks!

@jarohen jarohen closed this as completed Jul 10, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants