We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
There's a problem with the with-channel logic, specifically on lines 59 to 61:
with-channel
opts (when opts? opts) body (cond->> body (not opts?) (cons opts))
If opts? is false, then opts is bound to nil, and body is bound to (cons nil body).
opts?
opts
nil
body
(cons nil body)
To fix this, the opts rebinding should come after the body rebinding.
The text was updated successfully, but these errors were encountered:
Thanks James - I'll incorporate your fix when I get a moment. Failing that, if you've got a fork, could you submit a PR?
Cheers,
James
Sorry, something went wrong.
PR submitted (#19).
Fixed in #19 (deployed as 0.4.2), thanks!
No branches or pull requests
There's a problem with the
with-channel
logic, specifically on lines 59 to 61:If
opts?
is false, thenopts
is bound tonil
, andbody
is bound to(cons nil body)
.To fix this, the opts rebinding should come after the body rebinding.
The text was updated successfully, but these errors were encountered: