Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.5.0 fails to compile. #29

Closed
ianp opened this issue Jan 27, 2015 · 2 comments
Closed

0.5.0 fails to compile. #29

ianp opened this issue Jan 27, 2015 · 2 comments
Assignees

Comments

@ianp
Copy link

ianp commented Jan 27, 2015

As soon as I require [chord.client :refer [ws-ch]] I get the following error

clojure.lang.ExceptionInfo : Referred var fressian-cljs.fns/lookup does not exist at line 1
file:/Users/ianp/.m2/repository/net/unit8/fressian-cljs/0.1.0/fressian-cljs-0.1.0.jar!/fressian_cljs/reader.cljs

Which is annoying as I don't plan on using Fressian. I think that keeping the chord-fressian and chord-transit formats as separate dependencies was a better approach that lumping everything together in one project, this would also make it easier to add additional formats later on.

@jarohen jarohen self-assigned this Jan 27, 2015
@jarohen
Copy link
Owner

jarohen commented Jan 28, 2015

Thanks Ian - I've fixed this as of 0.6.0 - binary support is now in a separate namespace so shouldn't impact the require of chord.client.

Having the formats in separate libraries was a pain while the internals of Chord were changing - with the advent of AJAX support I had to make the format support more general, which would then have required co-ordinating changes in both chord-fressian and chord-transit. Users can still add additional formats through the defmulti, but we've moved common formats into the main library for ease of import.

Cheers,

James

@jarohen jarohen closed this as completed Jan 28, 2015
@ianp
Copy link
Author

ianp commented Jan 28, 2015

Cool, thanks for the quick response.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants